Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream v245 #115

Merged
merged 7 commits into from
May 13, 2024
Merged

Sync with upstream v245 #115

merged 7 commits into from
May 13, 2024

Conversation

Frzk
Copy link

@Frzk Frzk commented May 2, 2024

Tested here: https://fku-dummy-nodejs.osc-fr1.scalingo.io

Related to #114
Related to #60

dependabot bot and others added 6 commits April 11, 2024 09:31
heroku#1242)

Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.11 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.11...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add heroku-24 to the test matrix

* Run unit tests with explicit root user

* Run functional tests against heroku-24

* Add changelog entry for heroku-24

* Add --user root for makefile testing

* Use user owned dir instead of root user in makefile
* Update Inventory for heroku/nodejs engine

- Added Node.js version 22.0.0.

* Add hatchet tests for new major version (v22)

---------

Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Co-authored-by: Colin Casey <casey.colin@gmail.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
* pnpm support

These changes build on top of [existing corepack support](heroku#1222) to allow `pnpm` to be installed via [Corepack](https://nodejs.org/docs/latest/api/corepack.html).

The build process has also been modified use the `pnpm` binary at the following stages:
- installing dependencies
- running build scripts:
  - `heroku-prebuild`
  - `build` (or `heroku-postbuild`)
  - `heroku-cleanup`
- pruning dev dependencies

* Prune the pnpm store periodically (heroku#1231)

* Multiple lockfiles error (heroku#1228)

These changes build on top of [existing pnpm support](heroku#1224) and modify the failure message shown when multiple lockfiles are detected to now include pnpm.

* Add pnpm caching (heroku#1225)

These changes build on top of [existing pnpm support](heroku#1224) to allow `pnpm` dependencies to be saved and restored between builds.

* pnpm support (default version) (heroku#1226)

These changes build on top of [existing pnpm support](heroku#1224) to default to the `latest` version when it appears that pnpm should be used but there is no `engines.pnpm` or `packageManager` specified in `package.json`.

* pnpm support engines (heroku#1227)

These changes build on top of [existing pnpm support](heroku#1224) to use the version specified by the `engines.pnpm` field in `package.json`.

* Only prune when it's safe to do so (heroku#1238)

* Update CHANGELOG.md
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
@Frzk Frzk self-assigned this May 2, 2024
@Frzk Frzk marked this pull request as ready for review May 2, 2024 09:29
@Frzk Frzk requested a review from EtienneM May 2, 2024 09:37
@Frzk Frzk enabled auto-merge May 2, 2024 09:45
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also fixes #60. Can you update the description of your PR to highlight this?

@Frzk Frzk requested a review from EtienneM May 13, 2024 09:53
@Frzk Frzk merged commit e7278f5 into master May 13, 2024
@Frzk Frzk deleted the deps/upstream_v245 branch May 13, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants