Only prune when it's safe to do so #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
added
the
skip changelog
Merged
joshwlewis
reviewed
Apr 10, 2024
joshwlewis
reviewed
Apr 10, 2024
colincasey
force-pushed
the
pnpm_support_pruning
branch
from
17ba0b4
to
ca3923b
Compare
joshwlewis
approved these changes
Apr 10, 2024
colincasey
force-pushed
the
pnpm_support_pruning
branch
from
ca3923b
to
377755d
Compare
colincasey
added a commit
that referenced
this pull request
Apr 11, 2024
colincasey
added a commit
that referenced
this pull request
Apr 29, 2024
colincasey
added a commit
that referenced
this pull request
Apr 29, 2024
colincasey
added a commit
that referenced
this pull request
Apr 29, 2024
* pnpm support These changes build on top of [existing corepack support](#1222) to allow `pnpm` to be installed via [Corepack](https://nodejs.org/docs/latest/api/corepack.html). The build process has also been modified use the `pnpm` binary at the following stages: - installing dependencies - running build scripts: - `heroku-prebuild` - `build` (or `heroku-postbuild`) - `heroku-cleanup` - pruning dev dependencies * Prune the pnpm store periodically (#1231) * Multiple lockfiles error (#1228) These changes build on top of [existing pnpm support](#1224) and modify the failure message shown when multiple lockfiles are detected to now include pnpm. * Add pnpm caching (#1225) These changes build on top of [existing pnpm support](#1224) to allow `pnpm` dependencies to be saved and restored between builds. * pnpm support (default version) (#1226) These changes build on top of [existing pnpm support](#1224) to default to the `latest` version when it appears that pnpm should be used but there is no `engines.pnpm` or `packageManager` specified in `package.json`. * pnpm support engines (#1227) These changes build on top of [existing pnpm support](#1224) to use the version specified by the `engines.pnpm` field in `package.json`. * Only prune when it's safe to do so (#1238) * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the pnpm
8.15.6release, wheneverpnpm prunewould execute it would also execute anypreinstallorpostinstallscripts in package.json. This can cause build failures in applications that use these scripts along with dev dependencies (e.g.; the Nuxt starter project does this).To prevent this case, pruning will only be performed if:
pnpm < 8.15.6and there are nopreinstallorpostinstallscripts registeredpnpm >= 8.15.6If the above conditions are not met, a helpful warning will be shown and pruning will be skipped.