-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple lockfiles error #1228
Merged
Merged
Multiple lockfiles error #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
added
the
skip changelog
Changelog entry is not required - Skips changelog check
label
Mar 26, 2024
Merged
colincasey
force-pushed
the
pnpm_support
branch
from
March 27, 2024 16:06
0718093
to
060ecd5
Compare
colincasey
force-pushed
the
multiple_lockfiles_failure
branch
from
March 28, 2024 19:17
ee4de17
to
0622abb
Compare
colincasey
force-pushed
the
multiple_lockfiles_failure
branch
from
April 2, 2024 12:25
0622abb
to
b903149
Compare
joshwlewis
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion, not blocking.
colincasey
force-pushed
the
multiple_lockfiles_failure
branch
from
April 3, 2024 12:15
b903149
to
c5b286a
Compare
colincasey
force-pushed
the
pnpm_support
branch
2 times, most recently
from
April 4, 2024 16:01
26f9b42
to
c0f18d0
Compare
These changes build on top of [existing pnpm support](#1224) and modify the failure message shown when multiple lockfiles are detected to now include pnpm.
colincasey
force-pushed
the
multiple_lockfiles_failure
branch
from
April 4, 2024 16:24
c5b286a
to
a4dedef
Compare
colincasey
added a commit
that referenced
this pull request
Apr 29, 2024
These changes build on top of [existing pnpm support](#1224) and modify the failure message shown when multiple lockfiles are detected to now include pnpm.
colincasey
added a commit
that referenced
this pull request
Apr 29, 2024
* pnpm support These changes build on top of [existing corepack support](#1222) to allow `pnpm` to be installed via [Corepack](https://nodejs.org/docs/latest/api/corepack.html). The build process has also been modified use the `pnpm` binary at the following stages: - installing dependencies - running build scripts: - `heroku-prebuild` - `build` (or `heroku-postbuild`) - `heroku-cleanup` - pruning dev dependencies * Prune the pnpm store periodically (#1231) * Multiple lockfiles error (#1228) These changes build on top of [existing pnpm support](#1224) and modify the failure message shown when multiple lockfiles are detected to now include pnpm. * Add pnpm caching (#1225) These changes build on top of [existing pnpm support](#1224) to allow `pnpm` dependencies to be saved and restored between builds. * pnpm support (default version) (#1226) These changes build on top of [existing pnpm support](#1224) to default to the `latest` version when it appears that pnpm should be used but there is no `engines.pnpm` or `packageManager` specified in `package.json`. * pnpm support engines (#1227) These changes build on top of [existing pnpm support](#1224) to use the version specified by the `engines.pnpm` field in `package.json`. * Only prune when it's safe to do so (#1238) * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes build on top of existing pnpm support and modify the failure message shown when multiple lockfiles are detected to now include pnpm.