fix: add APT dependencies to some scripts for scalingo-24-minimal #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
force-pushed
the
feat/STORY-2477/scalingo-24-minimal
branch
from
eb95b19 to
14649eb
Compare
EtienneM
changed the title
m4 is a dependency
EtienneM
force-pushed
the
feat/STORY-2477/scalingo-24-minimal
branch
from
4fe814e to
ba5bc52
Compare
EtienneM
force-pushed
the
feat/STORY-2477/scalingo-24-minimal
branch
from
84286fa to
c542e43
Compare
EtienneM
commented
Sep 1, 2025
| fi | ||
|
|
||
| php_version="$1" | ||
| php_series="$(echo $php_version | cut -d '.' -f1,2)" |
There was a problem hiding this comment.
This variable is never used
| export C_INCLUDE_PATH="$C_INCLUDE_PATH:/app/vendor/libonig/include" | ||
| export PKG_CONFIG_PATH="/app/vendor/libonig/lib/pkgconfig:$PKG_CONFIG_PATH" | ||
|
|
||
| echo "-----> Downloading dependency WebP library ${webp_version}" |
There was a problem hiding this comment.
I just moved this earlier
| echo "-----> Downloading dependency zlib ${zlib_version}" | ||
| curl -LO "${PHP_BASE_URL}/zlib/zlib-${zlib_version}.tar.gz" | ||
| tar -xzvf "zlib-${zlib_version}.tar.gz" | ||
| tar -xzf "zlib-${zlib_version}.tar.gz" |
There was a problem hiding this comment.
I removed the verbosity of the tar calls as it pollutes stdout.
| ) | ||
|
|
||
| WITH_CURL_CONFIGURE="" | ||
| WITH_CURL_CONFIGURE="--with-curl=/usr" |
There was a problem hiding this comment.
This default value was already in the call to configure. We had a duplicated with-curl so I'm fixing this.
| export WEBP_LIBS="-L/app/vendor/libwebp/lib -lwebp" | ||
| export WEBP_CFLAGS="-I/app/vendor/libwebp/include" | ||
|
|
||
| ENABLE_GD_CONFIGURE="--enable-gd --with-jpeg --with-freetype --with-webp" |
There was a problem hiding this comment.
I added these options in the configure call directly, I find this clearer
| tar -xzf "zlib-${zlib_version}.tar.gz" | ||
|
|
||
| echo "-----> Downloading dependency libonig ${libonig_version}" | ||
| libzip_flag="" |
EtienneM
requested review from
a team and
briceamen
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the opportunity to slightly improve the
package_phpscript.Related to STORY-2492