Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP: Added the new Typescript 4.5 moduleResolutions #2100

Closed
wants to merge 1 commit into from

Conversation

frank-dspeed
Copy link

@frank-dspeed frank-dspeed commented Feb 23, 2022

Added the new Typescript 4.5 moduleResolutions as discribed https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html

WiP

I am Not sure if the repo supports versioning

Result of versioning issue

It is not possible without a built-in version.

With the built-in version it is still problematic in the JSON schema as there is only check with a single type number value. x.y.z is the type string format
The only proper implementation I can think of with the many multiple x.y.z-type string versions is this external schema which loads the correct JSON schema file via tag release.

Originally posted by @GerryFerdinandus in #2099 (comment)

@orta
Copy link
Contributor

orta commented Feb 26, 2022

These don't ship with TypeScript out of the box on production builds, we shouldn't really be adding them until they are available as it's likely more people will think its there and get it wrong vs the folks who have gone out of their way to install the builds with it enabled

@frank-dspeed
Copy link
Author

@orta your correct but it should be ready till it ships which is relativ near else it gets confusion and it takes time to setup the versioned json shemas

@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR is stale and will be closed in 7 days(auto-generated by stale action) label Apr 28, 2022
@frank-dspeed
Copy link
Author

not needed anymore while it was a interristing case typescript can now reference its own json shema via tsconfig it self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale PR is stale and will be closed in 7 days(auto-generated by stale action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants