Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncAPI Schema #2229

Merged
merged 1 commit into from
May 7, 2022
Merged

Add AsyncAPI Schema #2229

merged 1 commit into from
May 7, 2022

Conversation

Jman012
Copy link
Contributor

@Jman012 Jman012 commented May 6, 2022

Schema store: https://github.com/asyncapi/spec-json-schemas
AsyncAPI: https://www.asyncapi.com/

This is similar to OpenAPI.

@GerryFerdinandus
Copy link
Contributor

Thanks
Note:
"versions" only work if your special tooling support it.
Consider using the alternative solution for the future PR update. (See this PR)

@GerryFerdinandus GerryFerdinandus merged commit 9f50e7b into SchemaStore:master May 7, 2022
@smoya
Copy link
Contributor

smoya commented Jun 27, 2022

Thanks Note: "versions" only work if your special tooling support it. Consider using the alternative solution for the future PR update. (See this PR)

Now i understand what is the impact of this. I had to check how VS Code is not able to determine the version of the schema to use.
Let me also understand what are the requirements to, for example, make it work on VS Code:

Is that correct @GerryFerdinandus? Thanks.

@GerryFerdinandus
Copy link
Contributor

@smoya
That is correct.
Steps to take to make this work.

  1. on the asyncapi site create "https://raw.githubusercontent.com/asyncapi/spec-json-schemas/master/schemas/version.schema.json" which redirects to all different versions.
    Via check of "asyncapi" version
  2. Redirect the catalog.json to "https://raw.githubusercontent.com/asyncapi/spec-json-schemas/master/schemas/version.schema.json"
  3. delete the versions in the catalog.json. Because it's already implemented in step 1
  4. Keep updating the remote version.schema.json for each new added version.

@smoya
Copy link
Contributor

smoya commented Jul 13, 2022

The PR supporting all versions is now here #2342 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants