Skip to content

Update angular and deps to 16.2.1 #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 67 commits into from
Sep 7, 2023
Merged

Update angular and deps to 16.2.1 #1171

merged 67 commits into from
Sep 7, 2023

Conversation

bpedersen2
Copy link
Contributor

Still needs debugging

@bpedersen2 bpedersen2 mentioned this pull request Aug 21, 2023
Closed
@bpedersen2
Copy link
Contributor Author

Status:

  • Unit tests are passing
  • Routing is broken....

@bpedersen2 bpedersen2 force-pushed the jsup branch 2 times, most recently from 303aae6 to 1e7bdc4 Compare August 29, 2023 10:26
@bpedersen2 bpedersen2 marked this pull request as ready for review August 29, 2023 10:54
@bpedersen2
Copy link
Contributor Author

E2E tests are failing ( seems like the backend is just not reachable, still investigating)
Locally it now works.

TODOS:

  • review the CSS changes for all instituions
  • verify other customizations

@nitrosx
Copy link
Member

nitrosx commented Aug 29, 2023

@bpedersen2 have you checked if the accounts are correct? I mean the accounts info between frontend and backend.

@bpedersen2 bpedersen2 mentioned this pull request Sep 4, 2023
Closed
@bpedersen2
Copy link
Contributor Author

@bpedersen2 have you checked if the accounts are correct? I mean the accounts info between frontend and backend.

Yes, passwords were ok. But the it seems that the workflow used the old cypress.json config, I am retrying now with cypress.nestjs.json that uses different ports (#bc8c87f1).

@bpedersen2
Fix backend start command
1272eae 
Change-Id: I37199ab3b66aa919ec2e5c1bad7b2dc777e6b77e
@bpedersen2
Copy link
Contributor Author

@bpedersen2 have you checked if the accounts are correct? I mean the accounts info between frontend and backend.

Yes, passwords were ok. But the it seems that the workflow used the old cypress.json config, I am retrying now with cypress.nestjs.json that uses different ports (#bc8c87f1).

Another problem was the start command in the docker-compose file, main moved to dist/src/main, so the backedn really never started

@bpedersen2 bpedersen2 force-pushed the jsup branch 2 times, most recently from e546532 to be273a0 Compare September 4, 2023 10:16
@bpedersen2
Copy link
Contributor Author

Still TODO: review css

I can present the current look during tomorrows meeting

@nitrosx
Copy link
Member

nitrosx commented Sep 4, 2023

That's great!!!!
Do you want me to merge this PR, or should we wait?

@bpedersen2
Copy link
Contributor Author

We should discuss it tomorrow, I think.

@dependabot @bpedersen2
build(deps): bump actions/checkout from 3 to 4
72ae578 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@bpedersen2 bpedersen2 force-pushed the jsup branch 3 times, most recently from 5c05395 to b298538 Compare September 5, 2023 12:45
@bpedersen2
Use nestjs cypress config file
e84bfcf 
Change-Id: I7d141a9d55c1cad053688af51ba8f4c08e2500b8
@bpedersen2
Angular update
286c9d4 
Change-Id: I0f0416a45786102765d28875ac0b18c7e8ed10b3
@bpedersen2
a14
4b4af2c 
Change-Id: I0fa51de26a77678348e7e4e8986dd98c8959ab79
@bpedersen2
a14 p2
94dc7ef 
Change-Id: I3c6252ef7639287641409b5764f480e73aa75614
@bpedersen2
a15 p1
c03553f 
Change-Id: I3968f980d47a1dc213ce3161997b05dc81bf82f5
@bpedersen2
mdc migration
bc557b3 
Change-Id: If94171894c7b302bd1fbbd30b2a39403cc86c396
@bpedersen2
Remove deprecated ngMode + formControl
b96b770 
Change-Id: Ie0a994265a54a9f4bcb4b610c71045c49fa921c1
@bpedersen2
push single rows
fc3cfbf 
Change-Id: Iedee28a40205bd503d31b662690eccace68fdc80
@bpedersen2
Fix double import errors
11752a2 
Change-Id: I64bd447df08c785aa8445fb9067d9007958b0edb
@bpedersen2
Bump all dockerfiles to use node 18
df68128 
Change-Id: I2adafc065ef4bff7f5adc0b404e3cdd96709c2c0
@bpedersen2
Add karma reporter (sepc, junit)
b462419 
Change-Id: I8b50d3adf4ee3b7d1b0fa12103f6f8c5046bd168
@bpedersen2
Fix cypress lbBaseUrl
ba91a0c 
Change-Id: I8796c1dd0deb4c596574482d89f7e2f717b1b715
@bpedersen2
Add spec and junit reporters to karma conf
7212327 
Change-Id: If650a3c463b34f68ab516baf58df50cb1b911d1e
@bpedersen2
Fix cypress tests
a1909ee 
Some tags and classes did change, so adjust tests accordingly.

Change-Id: I4adccfac60fce0b15771c76fc425d084132de126
@bpedersen2
add padding to mat-card
8ba30f8 
Change-Id: Ie7422e81abf53e12c38913058dc9e014496810e8
@bpedersen2
css fixups
00e4294 
Change-Id: Ie9f73ec7b00d0e155dbee6213c66ecc02e954de3
@bpedersen2
more css fixup
8b4b357 
Change-Id: I480d7cb2bfb5c98d38b870ea1ece47b214e688ec
@bpedersen2
Fix user profile image
f2b27c3 
Change-Id: I10c41a31e900911386016a0a29429086e84f34b3
@bpedersen2
Fix dataset pid copy button size
ecc91fa 
Change-Id: I5a4cd16a5c7adbdd4b47592580af0db25b9f5d5e
@bpedersen2
dataset create button
df0b22f 
Change-Id: I6c5a1139168d35f4a8ff4c13f82e8f9fef1020fc
@bpedersen2
Update minor version
931475c 
Change-Id: Ib2135ad98bd02019ed7d0bd7469722d8b4170318
@bpedersen2
bump filesize from 6.4.0 to 10.0.7
86c217f 
Change-Id: Ia299c444d5ddc9060574a93202a624f400142839
@bpedersen2
bump socket.io-client to 4.7.2
afa35c0 
Change-Id: I846aaad12104b6f543be142f3dedf0817521e3f9
@bpedersen2 bpedersen2 force-pushed the jsup branch 2 times, most recently from a43d373 to c704228 Compare September 5, 2023 13:51
@bpedersen2
Bump cypress to 13.1.0
879024a 
Change-Id: I96558094ba1a0244c771ad3d83d55941246b4c53
@bpedersen2
USe cypress-action v6
bf757a9 
Change-Id: Ia555ee0421fcee531928b2b56bda8ef4ce5cba9a
@bpedersen2
Copy link
Contributor Author

Cypress update was the culprit, the config file changed from json to ts/js, see https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-100

@bpedersen2
don't use cpyress-file-upload
158549e 
Change-Id: Ib42d48845df570df07f691c9c61ce16e8b521884
@bpedersen2
Copy link
Contributor Author

Should be OK to merge now

enthusiastio
enthusiastio approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@enthusiastio enthusiastio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the node upgrade part here and it looks good, just a small comment

@bpedersen2
Use a var for node version and add it to cache key
2245ce9 
Change-Id: Ic98eaab5eedac394cfadb14c4a3178e392e74e2b
@nitrosx nitrosx merged commit 4f57ad8 into SciCatProject:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrosx nitrosx nitrosx approved these changes

@enthusiastio enthusiastio enthusiastio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpedersen2 @nitrosx @enthusiastio