-
Notifications
You must be signed in to change notification settings - Fork 19
1341 smm model with more indices #1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
- Coverage 97.28% 97.28% -0.01%
==========================================
Files 175 175
Lines 15306 15342 +36
==========================================
+ Hits 14891 14925 +34
- Misses 415 417 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Two comments on this: Fixing the copyright notice is entirely out of scope of this PR. That would be fine, if the changes was limited to a file with other modifications, which is not the case. Please move the copyright changes to a new PR. I guess gluing on the group indices works, but having to use std::apply whenever we need to index anything is frankly an awful user experience. Can you find a different solution? |
I already moved the changes to the docs branch, that will be merged first.
So far, this index is used exactly twice and I can't think of a reason to use it in the "frontend". Thus I would argue that the overhead of using this is manageable, especially as it doesn't require any other changes to existing code. |
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1341