feat: perform limited DAE initialization for null integrators/solutions #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
AayushSabharwal
force-pushed
the
as/param-init
branch
from
ae9e27b
to
dc231d4
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
dc231d4
to
fae7a7a
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
fae7a7a
to
c4c28a0
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
c4c28a0
to
95136c2
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
95136c2
to
76d3bde
Compare
| if SciMLBase.has_initializeprob(prob.f) && SciMLBase.has_initializeprobpmap(prob.f) | ||
| initializeprob = prob.f.initializeprob | ||
| nlsol = solve(initializeprob) | ||
| @set! prob.p = prob.f.initializeprobpmap(prob, nlsol) |
There was a problem hiding this comment.
Yeah. I think I wrote this when it was out-of-place, and didn't update it. Will edit and check
There was a problem hiding this comment.
No wait it's out of place 😅 with the idea that solving should not change the problem since then there's a chance for stateful errors where solving the same problem multiple times leads to different results
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires SciML/SciMLBase.jl#760 for the
constructorofmethodChecklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.