feat: support initializeprobpmap in relevant SciMLFunctions
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
why would optimizations have this? |
|
It doesn't. Those changes are from the format commit |
This was referenced Aug 6, 2024
Merged
AayushSabharwal
force-pushed
the
as/param-init
branch
from
4ca4e9b
to
c0f30cc
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
2 times, most recently
from
318197b
to
63d2fdc
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
63d2fdc
to
11f50a7
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
932cb31
to
df4e133
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
df4e133
to
ea8f92c
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
ea8f92c
to
a25ee6a
Compare
| @@ -174,6 +174,17 @@ function Base.setproperty!(prob::ODEProblem, s::Symbol, v, order::Symbol) | |||
| Base.setfield!(prob, s, v, order) | |||
| end | |||
|
|
|||
| function ConstructionBase.constructorof(::Type{P}) where {P <: ODEProblem} | |||
There was a problem hiding this comment.
For SciML/DiffEqBase.jl#1070, but it might not be now.
| use_defaults = false, | ||
| _kwargs...) | ||
| if tspan === missing | ||
| tspan = prob.tspan | ||
| end | ||
|
|
||
| newu0, newp = updated_u0_p(prob, u0, p; interpret_symbolicmap, use_defaults) | ||
| newu0, newp = updated_u0_p(prob, u0, p, tspan[1]; interpret_symbolicmap, use_defaults) |
There was a problem hiding this comment.
is this breaking downstream?
| @@ -693,7 +716,8 @@ function _updated_u0_p_symmap(prob, u0, ::Val{true}, p, ::Val{true}) | |||
| remake_buffer(prob, parameter_values(prob), keys(p), values(p)) | |||
| end | |||
|
|
|||
| function updated_u0_p(prob, u0, p; interpret_symbolicmap = true, use_defaults = false) | |||
| function updated_u0_p( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.