More robust method checking before wrapping #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #821 . The key is that promote_type ends up calling promote_rule, so it always has a method. We need to check if the promotion rules exist with duals to know if this we can do the wrapping. In the future, we can do further customization of the wrappers based on if the solver does AD or not, though that would likely increase compile times by a lot (since then there would be multiple versions of the solver), so I'm not convinced that's the right approach after. At least this is always safe, if not "too safe" in some sense.
ChrisRackauckas
force-pushed
the
robust_wrapping
branch
from
bd7f11f to
f9af71c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #821 . The key is that promote_type ends up calling promote_rule, so it always has a method. We need to check if the promotion rules exist with duals to know if this we can do the wrapping.
In the future, we can do further customization of the wrappers based on if the solver does AD or not, though that would likely increase compile times by a lot (since then there would be multiple versions of the solver), so I'm not convinced that's the right approach after. At least this is always safe, if not "too safe" in some sense.