Split DiffEqProblemLibrary into subpackages #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
force-pushed
the
dw/subpackages
branch
from
d751b19 to
b103e13
Compare
|
Apart from DiffEqProblemLibrary, all tests seem to pass now. DiffEqProblemLibrary fails since the subpackages are not registered yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits DiffEqProblemLibrary into subpackages ODEProblemLibrary, DDEProblemLibrary, DAEProblemLibrary, JumpProblemLibrary, and SDEProblemLibrary. DiffEqProblemLibrary only loads these packages (currently errors since the packages are not registered yet). I'm not completely sure about how to handle CI for subpackages, currently it's just multiple groups that run the tests in the subpackages separately and once the tests in DiffEqProblemLibrary. The last one is only strange one as the others are not dependent on each other - should the DiffEqProblemLibrary tests use only registered versions of these subpackages or check out their development version?
The PR is breaking since
importodeproblemsetc. are removed. I used the opportunity and removed the deprecated DDE problems as well.Fixes #87.