Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single dimensional batch tests are broken #1

Closed
ChrisRackauckas opened this issue Sep 11, 2019 · 2 comments
Closed

Single dimensional batch tests are broken #1

ChrisRackauckas opened this issue Sep 11, 2019 · 2 comments

Comments

@ChrisRackauckas
Copy link
Member

[ Info: Dimension = 1, Alg = VEGAS(100, 1000), Integrand = 1
Converged in 1000 evaluations
nevals = 1000
[ Info: Dimension = 1, Alg = CubatureJLh(), Integrand = 1
[ Info: Dimension = 1, Alg = CubatureJLp(), Integrand = 1
[ Info: Dimension = 1, Alg = CubaVegas(), Integrand = 1
[ Info: Dimension = 1, Alg = CubaSUAVE(), Integrand = 1
[ Info: Dimension = 1, Alg = VEGAS(100, 1000), Integrand = 2
Converged in 177000 evaluations
nevals = 177000
[ Info: VEGAS(100, 1000) failed
(sol.u, _sol.u) = (4.000095651237495, 60.0)
[ Info: Dimension = 1, Alg = CubatureJLh(), Integrand = 2
[ Info: Dimension = 1, Alg = CubatureJLp(), Integrand = 2
[ Info: CubatureJLp() failed
(sol.u, _sol.u) = (12.0, 60.0)
[ Info: Dimension = 1, Alg = CubaVegas(), Integrand = 2
[ Info: CubaVegas() failed
(sol.u, _sol.u) = (4.001139501949519, 60.0)
[ Info: Dimension = 1, Alg = CubaSUAVE(), Integrand = 2
[ Info: CubaSUAVE() failed
(sol.u, _sol.u) = (3.999560368540787, 60.0)
[ Info: Dimension = 1, Alg = VEGAS(100, 1000), Integrand = 3
Converged in 101000 evaluations
nevals = 101000
[ Info: VEGAS(100, 1000) failed
(sol.u, _sol.u) = (1.5295789271704923, 20.900856510613945)
[ Info: Dimension = 1, Alg = CubatureJLh(), Integrand = 3
[ Info: Dimension = 1, Alg = CubatureJLp(), Integrand = 3
[ Info: CubatureJLp() failed
(sol.u, _sol.u) = (3.7837768393868902, 20.900856510613945)
[ Info: Dimension = 1, Alg = CubaVegas(), Integrand = 3
[ Info: CubaVegas() failed
(sol.u, _sol.u) = (1.5296718426011646, 20.900856510613945)
[ Info: Dimension = 1, Alg = CubaSUAVE(), Integrand = 3
[ Info: CubaSUAVE() failed
(sol.u, _sol.u) = (1.5302221213067564, 20.900856510613945)
Test Summary:                       | Pass  Broken  Total
Batched Single Dimension Integrands |    7       8     15

It looks like MonteCarloIntegration.jl and Cuba.jl are interpreting it the same way, while CubatureJLh and CubatureJLp are doing two entirely different things. I haven't looked into who's correct here.

@ChrisRackauckas
Copy link
Member Author

Seems like it's a Cubature.jl issue.

@agerlach
Copy link
Collaborator

agerlach commented Jun 3, 2020

#20

ChrisRackauckas pushed a commit that referenced this issue Sep 21, 2023
add init interface for SampledIntegralProblem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants