Clean up sparse handling #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChrisRackauckas
commented
Jan 3, 2023
ChrisRackauckas
commented
- Fix case with sparse b, fixes Linear solve fails when rhs is sparse vector #248
- Removes Sparspak from the section off code that's only for non-GPL cases. Sparspak.jl isn't GPL-licensed so we can always use it.
- Restructured the default algorithm so that Sparspak is used when GPL is disabled, making it so it can always factorize properly.
- Fix case with sparse b, fixes #248 - Removes Sparspak from the section off code that's only for non-GPL cases. Sparspak.jl isn't GPL-licensed so we can always use it. - Restructured the default algorithm so that Sparspak is used when GPL is disabled, making it so it can always factorize properly.
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 65.81% 65.32% -0.49%
==========================================
Files 12 12
Lines 740 744 +4
==========================================
- Hits 487 486 -1
- Misses 253 258 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.