-
-
Notifications
You must be signed in to change notification settings - Fork 70
Pardiso #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pardiso #37
Conversation
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 85.50% 85.31% -0.20%
==========================================
Files 5 6 +1
Lines 276 320 +44
==========================================
+ Hits 236 273 +37
- Misses 40 47 +7
Continue to review full report at Codecov.
|
@ChrisRackauckas i got some boilerplate code with a little functionality. can you point me to usecases in sciml ecosystem to test against so i can figure what more to add if needed? else i can test this with the examples in https://github.com/JuliaSparse/Pardiso.jl/tree/master/examples |
this is largely done - just need to figure out the right defaults |
src/pardiso.jl
Outdated
|
||
import Pardiso | ||
|
||
export PardisoJL, PardisoJLFactorize, PardisoJLIterate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't pardiso have a mixed factorized and iterate thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - ANALYSIS_NUM_FACT_SOLVE_REFINE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing that too
@KristofferC , we're writing a Pardiso.jl wrapper for SciML ecosystem. Would like for you to have a look at this. I was also wondering how one could control |
This looks good to merge. Of course, more can be tweaked in further PRs as better defaults are found. |
todo
close #5