Skip to content

Pardiso #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 11, 2021
Merged

Pardiso #37

merged 15 commits into from
Dec 11, 2021

Conversation

vpuri3
Copy link
Member

@vpuri3 vpuri3 commented Dec 9, 2021

todo

  • finish boilerplate
  • test on some realistic sciml usecase
  • test on pardiso.jl/examples

close #5

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #37 (2d3822f) into main (e99d699) will decrease coverage by 0.19%.
The diff coverage is 83.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   85.50%   85.31%   -0.20%     
==========================================
  Files           5        6       +1     
  Lines         276      320      +44     
==========================================
+ Hits          236      273      +37     
- Misses         40       47       +7     
Impacted Files Coverage Δ
src/wrappers.jl 91.15% <ø> (ø)
src/pardiso.jl 83.33% <83.33%> (ø)
src/LinearSolve.jl 62.50% <100.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99d699...2d3822f. Read the comment docs.

@vpuri3
Copy link
Member Author

vpuri3 commented Dec 9, 2021

@ChrisRackauckas i got some boilerplate code with a little functionality. can you point me to usecases in sciml ecosystem to test against so i can figure what more to add if needed? else i can test this with the examples in https://github.com/JuliaSparse/Pardiso.jl/tree/master/examples

@vpuri3
Copy link
Member Author

vpuri3 commented Dec 9, 2021

this is largely done - just need to figure out the right defaults

src/pardiso.jl Outdated

import Pardiso

export PardisoJL, PardisoJLFactorize, PardisoJLIterate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't pardiso have a mixed factorized and iterate thing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - ANALYSIS_NUM_FACT_SOLVE_REFINE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing that too

@vpuri3
Copy link
Member Author

vpuri3 commented Dec 11, 2021

@KristofferC , we're writing a Pardiso.jl wrapper for SciML ecosystem. Would like for you to have a look at this. I was also wondering how one could control abstol, and reltol. Would it be possible by supplying appropriate iparm/dparms?? cant find any reference to tolerance in docs

@vpuri3 vpuri3 changed the title WIP - Pardiso Pardiso Dec 11, 2021
@ChrisRackauckas ChrisRackauckas merged commit 137eed4 into SciML:main Dec 11, 2021
@ChrisRackauckas
Copy link
Member

This looks good to merge. Of course, more can be tweaked in further PRs as better defaults are found.

@vpuri3 vpuri3 deleted the vp-pardiso branch December 11, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pardiso wrappers
2 participants