Fix defaultalg method ambiguity for SciMLOp + GPUArray #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should fix this error
```julia
Candidates:
defaultalg(A::SciMLOperators.AbstractSciMLOperator, b, assump::LinearSolve.OperatorAssumptions)
@ LinearSolve ~/.julia/packages/LinearSolve/Rq2MY/src/default.jl:132
defaultalg(A, b::GPUArraysCore.AbstractGPUArray, assump::LinearSolve.OperatorAssumptions)
@ LinearSolve ~/.julia/packages/LinearSolve/Rq2MY/src/default.jl:106
Possible fix, define
defaultalg(::SciMLOperators.AbstractSciMLOperator, ::GPUArraysCore.AbstractGPUArray, ::LinearSolve.OperatorAssumptions)
```
Codecov Report
@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 68.25% 68.45% +0.19%
==========================================
Files 24 24
Lines 1884 1880 -4
==========================================
+ Hits 1286 1287 +1
+ Misses 598 593 -5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
add a test? |
|
Updated version is in 049af43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix this error