Make FastLapackInterface.jl an extension as well #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/src/solvers/solvers.md
Outdated
| be faster than the Base.LinearAlgebra version. | ||
| be faster than the Base.LinearAlgebra version. In practice, with the way we wrap the solvers, | ||
| we do not see a performance benefit and in fact benchmarks tend to show this inhibits | ||
| performance. |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| performance. | |
| performance. |
| maxiters::Int, abstol, reltol, verbose::Bool, | ||
| assumptions::OperatorAssumptions) | ||
| ws = LUWs(A) | ||
| return WorkspaceAndFactors(ws, LinearSolve.ArrayInterface.lu_instance(convert(AbstractMatrix, A))) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return WorkspaceAndFactors(ws, LinearSolve.ArrayInterface.lu_instance(convert(AbstractMatrix, A))) | |
| return WorkspaceAndFactors( | |
| ws, LinearSolve.ArrayInterface.lu_instance(convert(AbstractMatrix, A))) |
| return WorkspaceAndFactors(ws, LinearSolve.ArrayInterface.lu_instance(convert(AbstractMatrix, A))) | ||
| end | ||
|
|
||
| function SciMLBase.solve!(cache::LinearSolve.LinearCache, alg::FastLUFactorization; kwargs...) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function SciMLBase.solve!(cache::LinearSolve.LinearCache, alg::FastLUFactorization; kwargs...) | |
| function SciMLBase.solve!( | |
| cache::LinearSolve.LinearCache, alg::FastLUFactorization; kwargs...) |
| if cache.isfresh | ||
| # we will fail here if A is a different *size* than in a previous version of the same cache. | ||
| # it may instead be desirable to resize the workspace. | ||
| LinearSolve.@set! ws_and_fact.factors = LinearAlgebra.LU(LAPACK.getrf!(ws_and_fact.workspace, |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| LinearSolve.@set! ws_and_fact.factors = LinearAlgebra.LU(LAPACK.getrf!(ws_and_fact.workspace, | |
| LinearSolve.@set! ws_and_fact.factors = LinearAlgebra.LU(LAPACK.getrf!( | |
| ws_and_fact.workspace, |
| SciMLBase.build_linear_solution(alg, y, nothing, cache) | ||
| end | ||
|
|
||
| function LinearSolve.init_cacheval(alg::FastQRFactorization{NoPivot}, A::AbstractMatrix, b, u, Pl, Pr, |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function LinearSolve.init_cacheval(alg::FastQRFactorization{NoPivot}, A::AbstractMatrix, b, u, Pl, Pr, | |
| function LinearSolve.init_cacheval( | |
| alg::FastQRFactorization{NoPivot}, A::AbstractMatrix, b, u, Pl, Pr, |
| return WorkspaceAndFactors(ws, | ||
| LinearSolve.ArrayInterface.qr_instance(convert(AbstractMatrix, A))) | ||
| end | ||
| function LinearSolve.init_cacheval(::FastQRFactorization{ColumnNorm}, A::AbstractMatrix, b, u, Pl, Pr, |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function LinearSolve.init_cacheval(::FastQRFactorization{ColumnNorm}, A::AbstractMatrix, b, u, Pl, Pr, | |
| function LinearSolve.init_cacheval( | |
| ::FastQRFactorization{ColumnNorm}, A::AbstractMatrix, b, u, Pl, Pr, |
| assumptions::OperatorAssumptions) | ||
| ws = QRpWs(A) | ||
| return WorkspaceAndFactors(ws, | ||
| LinearSolve.ArrayInterface.qr_instance(convert(AbstractMatrix, A))) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| LinearSolve.ArrayInterface.qr_instance(convert(AbstractMatrix, A))) | |
| LinearSolve.ArrayInterface.qr_instance(convert(AbstractMatrix, A))) |
Comment on lines
81
to
82
|
|
||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.