Skip to content

MTK doesn't support complex equations of motion since MTK@v9.73 #3763

@oameye

Description

@oameye

In MTK@v9.73, the function float_type_from_varmap was introduced, but doesn't cover complex eqautions of motion.

"""
$(TYPEDSIGNATURES)
Calculate the floating point type to use from the given `varmap` by looking at variables
with a constant value.
"""
function float_type_from_varmap(varmap, floatT = Bool)
for (k, v) in varmap
symbolic_type(v) == NotSymbolic() || continue
is_array_of_symbolics(v) && continue
if v isa AbstractArray
floatT = promote_type(floatT, eltype(v))
elseif v isa Real
floatT = promote_type(floatT, typeof(v))
end
end
return float(floatT)
end

This will make it one solves the system with OrdinaryDiffEq, one hits:

ERROR: InexactError: Float64(0.0 + 5.0im)
Stacktrace:
  [1] Real
    @ ./complex.jl:44 [inlined]
  [2] _broadcast_getindex_evalf
    @ ./broadcast.jl:709 [inlined]
  [3] _broadcast_getindex
    @ ./broadcast.jl:682 [inlined]
  [4] getindex
    @ ./broadcast.jl:636 [inlined]
  [5] macro expansion
    @ ./broadcast.jl:1004 [inlined]
  [6] macro expansion
    @ ./simdloop.jl:77 [inlined]
  [7] copyto!
    @ ./broadcast.jl:1003 [inlined]
  [8] copyto!
    @ ./broadcast.jl:956 [inlined]
  [9] copy
    @ ./broadcast.jl:928 [inlined]
 [10] materialize(bc::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{…}, Nothing, Type{…}, Tuple{…}})
    @ Base.Broadcast ./broadcast.jl:903
 [11] better_varmap_to_vars(varmap::Dict{…}, vars::Vector{…}; tofloat::Bool, container_type::Type, floatT::Type, toterm::Function, promotetoconcrete::Nothing, check::Bool, allow_symbolic::Bool, is_initializeprob::Bool)
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/15RQb/src/systems/problem_utils.jl:370
 [12] process_SciMLProblem(constructor::Type, sys::ODESystem, u0map::Vector{…}, pmap::Vector{…}; build_initializeprob::Bool, implicit_dae::Bool, t::Float64, guesses::Dict{…}, warn_initialize_determined::Bool, initialization_eqs::Vector{…}, eval_expression::Bool, eval_module::Module, fully_determined::Nothing, check_initialization_units::Bool, tofloat::Bool, u0_constructor::typeof(identity), du0map::Nothing, check_length::Bool, symbolic_u0::Bool, warn_cyclic_dependency::Bool, circular_dependency_max_cycle_length::Int64, circular_dependency_max_cycles::Int64, substitution_limit::Int64, use_scc::Bool, force_initialization_time_independent::Bool, algebraic_only::Bool, allow_incomplete::Bool, is_initializeprob::Bool, kwargs::@Kwargs{})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/15RQb/src/systems/problem_utils.jl:888
 [13] (ODEProblem{})(sys::ODESystem, u0map::Vector{…}, tspan::Tuple{…}, parammap::Vector{…}; allow_cost::Bool, callback::Nothing, check_length::Bool, warn_initialize_determined::Bool, eval_expression::Bool, eval_module::Module, kwargs::@Kwargs{})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/15RQb/src/systems/diffeqs/abstractodesystem.jl:801
 [14] (ODEProblem{})(sys::ODESystem, u0map::Vector{…}, tspan::Tuple{…}, parammap::Vector{…})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/15RQb/src/systems/diffeqs/abstractodesystem.jl:776
 [15] (ODEProblem{true})(::ODESystem, ::Vector{ComplexF64}, ::Vararg{Any}; kwargs::@Kwargs{})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/15RQb/src/systems/diffeqs/abstractodesystem.jl:769
 [16] (ODEProblem{true})(::ODESystem, ::Vector{ComplexF64}, ::Vararg{Any})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/15RQb/src/systems/diffeqs/abstractodesystem.jl:768
 [17] ODEProblem(::ODESystem, ::Vector{ComplexF64}, ::Vararg{Any}; kwargs::@Kwargs{})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/15RQb/src/systems/diffeqs/abstractodesystem.jl:758
 [18] ODEProblem(::ODESystem, ::Vector{ComplexF64}, ::Vararg{Any})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/15RQb/src/systems/diffeqs/abstractodesystem.jl:757
 [19] top-level scope
    @ ~/Documents/QuantumCumulants.jl/test/MTK@9.73.jl:68

As this sliped through the cracks, on should probably add a complex equations of motion system to the test suite.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions