Pirated functions with Symbolics.jl

[imciner2]

I was just updating my 1.5.3 installation to newer package versions (ModelingToolkit to 5.12.1 and Symbolics.jl added as a new dep at 0.1.5) when I saw some type piracy warnings during precompilation of the DifferentialEquations package:

[ Info: Precompiling DifferentialEquations [0c46a032-eb83-5123-abaf-570d42b7fbaa]
WARNING: Method definition substitute(Symbolics.Num, Base.Dict{K, V} where V where K) in module Symbolics at /home/imcinerney/.julia/packages/Symbolics/XVpe1/src/num.jl:63 overwritten in module ModelingToolkit at /home/imcinerney/.julia/packages/ModelingToolkit/Df3sc/src/utils.jl:65.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition substitute##kw(Any, typeof(SymbolicUtils.substitute), Symbolics.Num, Base.Dict{K, V} where V where K) in module Symbolics at /home/imcinerney/.julia/packages/Symbolics/XVpe1/src/num.jl:63 overwritten in module ModelingToolkit at /home/imcinerney/.julia/packages/ModelingToolkit/Df3sc/src/utils.jl:65.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition substitute##kw(Any, typeof(SymbolicUtils.substitute), Symbolics.Num, Base.Dict{K, V} where V where K) in module Symbolics at /home/imcinerney/.julia/packages/Symbolics/XVpe1/src/num.jl:63 overwritten in module ModelingToolkit at /home/imcinerney/.julia/packages/ModelingToolkit/Df3sc/src/utils.jl:65.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition substitute(Symbolics.Num, Base.Dict{K, V} where V where K) in module Symbolics at /home/imcinerney/.julia/packages/Symbolics/XVpe1/src/num.jl:63 overwritten in module ModelingToolkit at /home/imcinerney/.julia/packages/ModelingToolkit/Df3sc/src/utils.jl:65.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition substitute##kw(Any, typeof(SymbolicUtils.substitute), Symbolics.Num, Base.Dict{K, V} where V where K) in module Symbolics at /home/imcinerney/.julia/packages/Symbolics/XVpe1/src/num.jl:63 overwritten in module ModelingToolkit at /home/imcinerney/.julia/packages/ModelingToolkit/Df3sc/src/utils.jl:65.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition substitute(Symbolics.Num, Base.Dict{K, V} where V where K) in module Symbolics at /home/imcinerney/.julia/packages/Symbolics/XVpe1/src/num.jl:63 overwritten in module ModelingToolkit at /home/imcinerney/.julia/packages/ModelingToolkit/Df3sc/src/utils.jl:65.
  ** incremental compilation may be fatally broken for this module **

I am not sure which package is pirating which function here, but it should probably be addressed in one of the packages.

[ChrisRackauckas]

oh I see what happened.

https://github.com/SciML/ModelingToolkit.jl/blob/master/src/utils.jl#L38-L85

which collides with the new:

JuliaSymbolics/Symbolics.jl#96

Those should all be moved to Symbolics.jl. @shashi do you prefer the MTK version of substitute(x::Num, rule::Dict; kw...) or the new one? I'm not so sure about the difference.

@MasonProtter