New abstract time dependent/independent types & `independent_variables` method #1091

lamorton · 2021-07-02T04:14:16Z

This addresses #1082. AbstractSystems are now categorized into 3 classes (0, 1, N independent variables). The independent_variable method has been replaced with independent_variables which returns any/all independent variables for any type of system. Use get_iv where it is known that only one independent variable exists (ie, for AbstractTimeDependentSystems).

…n them.

… and fixing arising problems downstream.

…e of `independent_variable`. Presently not able to refer to the abstract types from within `StructuralTransformations`, so using ODEsystem in pantelides.jl

…d docs & tests.

docs/src/basics/AbstractSystem.md

lamorton · 2021-07-02T16:57:49Z

NeuralPDE integration test is failing b/c I changed PDESystem.indvars to PDESystem.ivs. I've got a PR read to deal with that. Is there a way to deprecate access like this?

Also, the @deprecate independent_variables seems not to be providing a warning, and I don't understand why.

src/systems/abstractsystem.jl

…independent_variable`.

…uld fix integration tests.

src/systems/pde/pdesystem.jl

Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>

…rs`.

src/systems/pde/pdesystem.jl

…endence # Conflicts: # docs/src/systems/SDESystem.md # src/ModelingToolkit.jl # src/structural_transformation/StructuralTransformations.jl

lamorton · 2021-07-18T17:38:34Z

I think the NeuralPDE test failure is unrelated.

# Conflicts: # src/systems/abstractsystem.jl # src/systems/diffeqs/abstractodesystem.jl

…lly weight-bearing downstream in DataDrivenDiffEq. This reverts commit 98da595.

lamorton · 2021-07-25T22:10:45Z

Looks like that fallback method for independent_variables was important after all: DataDrivenDiffEq declares Basis<:AbstractSystem. I'm adding that method back & putting some tests for it to meet the coverage tests.

lamorton · 2021-08-01T19:42:15Z

Is the coverage the only thing preventing this from being merged?

ChrisRackauckas · 2021-08-01T20:26:04Z

No, I think it was just JuliaCon 😅 . I'd like @YingboMa to take a look first before merging.

YingboMa · 2021-08-04T22:56:03Z

src/systems/pde/pdesystem.jl

 ```
 """
-struct PDESystem <: ModelingToolkit.AbstractSystem
+struct PDESystem <: ModelingToolkit.AbstractMultivariateSystem


Remove ModelingToolkit.

src/systems/systemstructure.jl

YingboMa · 2021-08-04T23:03:36Z

I think this is good to merge, though, please squash the commits appropriately.

Also, we should merge other bug fixes PR and do a patch/minor release before merging this PR. After this PR, and together with #1157, we should do a new major release.

PS: If you are using git from the command line, you can always do git commit --amend if you want to fix a small typo with making a new commit.

lamorton · 2021-08-06T22:18:14Z

@YingboMa Thanks for taking care of the loose ends here.

lamorton added 7 commits June 26, 2021 10:15

Create AbstractTimeDependent & TimeIndependent types and specialize o…

fe9090b

…n them.

Add AbstractMultivariateSystem for PDEs.

3764b2b

Started replacing independent_variable with independent_variables…

a540132

… and fixing arising problems downstream.

Start using new abstract types to specialize functions & replace usag…

3ec9ada

…e of `independent_variable`. Presently not able to refer to the abstract types from within `StructuralTransformations`, so using ODEsystem in pantelides.jl

More replacements.

1d05641

Finished removing independent_variable and references to it. Update…

60a8c8d

…d docs & tests.

Documentation of the type hierarchy.

54d8734

ChrisRackauckas reviewed Jul 2, 2021

View reviewed changes

docs/src/basics/AbstractSystem.md Show resolved Hide resolved

lamorton added 2 commits July 2, 2021 08:22

Put independent_variable back, but with a deprecation warning.

bf4da6f

Merge branch 'master' into time_dependence

2c5fa9a

YingboMa reviewed Jul 2, 2021

View reviewed changes

src/systems/abstractsystem.jl Outdated Show resolved Hide resolved

lamorton added 2 commits July 3, 2021 09:26

Fixed deprecation warning & went back to original implementation of `…

d199de6

…independent_variable`.

Provided (deprecated) way to get sys.indvars and sys.depvars. Sho…

f83a4d2

…uld fix integration tests.

ChrisRackauckas reviewed Jul 3, 2021

View reviewed changes

src/systems/pde/pdesystem.jl Outdated Show resolved Hide resolved

ChrisRackauckas reviewed Jul 3, 2021

View reviewed changes

src/systems/pde/pdesystem.jl Outdated Show resolved Hide resolved

lamorton and others added 3 commits July 3, 2021 13:19

Update src/systems/pde/pdesystem.jl

6c82c3c

Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>

Update src/systems/pde/pdesystem.jl

d8b12db

Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>

Provide fallback with warning & remove reference to deprecated `indva…

912bf50

…rs`.

YingboMa reviewed Jul 3, 2021

View reviewed changes

src/systems/pde/pdesystem.jl Outdated Show resolved Hide resolved

lamorton added 3 commits July 17, 2021 12:05

Merge commit 'e8ab7105fe416b1eae89dcaa22a692dd897309f8' into time_dep…

4fb9d3a

…endence # Conflicts: # docs/src/systems/SDESystem.md # src/ModelingToolkit.jl # src/structural_transformation/StructuralTransformations.jl

Fixed new mentions of deprecated 'independent_variable'.

dc14118

Force depwarn.

13b1c89

lamorton added 3 commits July 25, 2021 11:38

Merge branch 'master' into time_dependence.

53488f3

# Conflicts: # src/systems/abstractsystem.jl # src/systems/diffeqs/abstractodesystem.jl

Deleted fallback method b/c it was redundant.

98da595

Add test for an instance of AbstractMultivariateSystem.

7d455e3

ChrisRackauckas approved these changes Jul 25, 2021

View reviewed changes

lamorton added 2 commits July 25, 2021 13:40

Corrected mistaken test.

9a930bd

Revert "Deleted fallback method b/c it was redundant." This was actua…

e40f62f

…lly weight-bearing downstream in DataDrivenDiffEq. This reverts commit 98da595.

lamorton added 4 commits July 25, 2021 15:12

Improve warning message.

a768cad

Use preferred method.

96adab9

Fix deprecated usage that crept in from master branch.

e90d8dd

Adding tests for fallback method for AbstractSystems.

6f25123

YingboMa reviewed Aug 4, 2021

View reviewed changes

src/systems/systemstructure.jl Show resolved Hide resolved

YingboMa merged commit 89fdee8 into SciML:master Aug 6, 2021

lamorton deleted the time_dependence branch August 7, 2021 00:31

This was referenced Aug 7, 2021

Abstract time dependent/independent system types #1082

Closed

Nonlinear problems does not seem to follow the same interface as ODESystems #1074

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

New abstract time dependent/independent types & `independent_variables` method #1091

New abstract time dependent/independent types & `independent_variables` method #1091

Uh oh!

lamorton commented Jul 2, 2021

Uh oh!

Uh oh!

lamorton commented Jul 2, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lamorton commented Jul 18, 2021

Uh oh!

lamorton commented Jul 25, 2021

Uh oh!

lamorton commented Aug 1, 2021

Uh oh!

ChrisRackauckas commented Aug 1, 2021

Uh oh!

YingboMa Aug 4, 2021

Uh oh!

Uh oh!

YingboMa commented Aug 4, 2021

Uh oh!

lamorton commented Aug 6, 2021

Uh oh!

Uh oh!

Uh oh!

New abstract time dependent/independent types & independent_variables method #1091

New abstract time dependent/independent types & independent_variables method #1091

Uh oh!

Conversation

lamorton commented Jul 2, 2021

Uh oh!

Uh oh!

lamorton commented Jul 2, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lamorton commented Jul 18, 2021

Uh oh!

lamorton commented Jul 25, 2021

Uh oh!

lamorton commented Aug 1, 2021

Uh oh!

ChrisRackauckas commented Aug 1, 2021

Uh oh!

YingboMa Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

YingboMa commented Aug 4, 2021

Uh oh!

lamorton commented Aug 6, 2021

Uh oh!

Uh oh!

New abstract time dependent/independent types & `independent_variables` method #1091

New abstract time dependent/independent types & `independent_variables` method #1091