Variable scope: don't lose metadata by passing around bare symbols #1092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into another instance where the code takes a symbolic value, namespaces it, takes the name (discarding metadata) and uses that to rename the original symbol (with the old metadata).
This was not caught in the tests because the tests use
renamespace
directly and mostly usedSym
rather thanTerm
which trigger this code path. I've added a testcase for that now.I seem to recall there was some test failure in a completely different test, so while I can't see why, I'm semi-expecting a CI failure. Let's see...