Skip to content

Conversation

pepijndevos
Copy link
Contributor

I ran into another instance where the code takes a symbolic value, namespaces it, takes the name (discarding metadata) and uses that to rename the original symbol (with the old metadata).

This was not caught in the tests because the tests use renamespace directly and mostly used Sym rather than Term which trigger this code path. I've added a testcase for that now.

I seem to recall there was some test failure in a completely different test, so while I can't see why, I'm semi-expecting a CI failure. Let's see...

@pepijndevos
Copy link
Contributor Author

Yeah that's the CI error I was expecting. Except I can't remember where it happened before and what I did to solve it. @YingboMa you remember by any chance?

I guess I need to figure out how to reproduce this testcase locally... bleg

@pepijndevos
Copy link
Contributor Author

This failure does not seem to be cause by my changes. I checked out DataDrivenDiffEq.jl locally and it gives this test failure without my changes.

@ChrisRackauckas
Copy link
Member

That's the symbolic array issues. Don't worry about DataDriven's failure.

@ChrisRackauckas ChrisRackauckas merged commit 056e3c2 into SciML:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants