Skip to content

switch LightGraphs to Graphs #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

isaacsas
Copy link
Member

This would require a new breaking release I guess, so perhaps best to merge when ready to go to 7.0.

@isaacsas
Copy link
Member Author

@ChrisRackauckas I'll leave this for you or @YingboMa to merge when ready since I don't want to mess up any planned non-breaking releases or such in the near future.

@YingboMa
Copy link
Member

Could this be breaking to anyone? Maybe this is fine.

@isaacsas
Copy link
Member Author

Maybe it isn't here. It is in Catalyst since we'll now return and expect users to pass a Graphs.DiGraph for some API functions. I guess the MT usage is entirely internal though.

@isaacsas isaacsas closed this Nov 2, 2021
@isaacsas isaacsas reopened this Nov 2, 2021
@isaacsas
Copy link
Member Author

isaacsas commented Nov 2, 2021

@ChrisRackauckas can we merge this with the Symbolics 4 changes for the next release?

@ChrisRackauckas ChrisRackauckas merged commit 0784a4a into SciML:master Nov 2, 2021
@ChrisRackauckas
Copy link
Member

Good idea.

@isaacsas isaacsas deleted the drop_lightgraphs branch November 2, 2021 12:46
ChrisRackauckas pushed a commit that referenced this pull request Aug 1, 2025
This commit creates the branch for fixing line splits following
Catalyst.jl PR #1306 guidelines. Further fixes to be added.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants