Patch concrete init #1490
Merged
Patch concrete init #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils.jl
Outdated
| vs | ||
| else | ||
| C = foldl((t, elem)->promote_type(t, eltype(elem)), vs; init=typeof(first(vs))) | ||
| convert(Vector{C}, vs) |
There was a problem hiding this comment.
It's not always a vector, or at least, not always supposed to be a vector. I think you want to instead just broadcast a convert to C.
There was a problem hiding this comment.
I see, it could be a Tuple, this seems to be missing from the test then.
ChrisRackauckas
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adds concrete type promotion for
u0, otherwise solvers likeRosenbrock23throw an exception. This was present inv8.5.2. Parameters can have mixed types, though.