Skip to content

Conversation

anandijain
Copy link
Contributor

closes #1281

Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout similarterm

Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YingboMa
Copy link
Member

YingboMa commented May 1, 2022

Test failure is unrelated.

@YingboMa YingboMa merged commit 5f250f6 into SciML:master May 1, 2022
@anandijain
Copy link
Contributor Author

Shouldn't I have removed the Symbolics.substitute dispatch first though?

@YingboMa
Copy link
Member

YingboMa commented May 1, 2022

Ahhhh, yeah. Please do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert_system(ODESystem, sys, independent_variable(sys2) gives ArgumentError: Cannot find the parent of ...
2 participants