Skip to content

hashing for discrete cb conditions #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

wsphillips
Copy link
Contributor

@wsphillips wsphillips commented Aug 2, 2022

bugfix for hashing the condition of SymbolicDiscreteCallback, which can be a Num. Fixes #1717 (comment)

@isaacsas
Copy link
Member

isaacsas commented Aug 2, 2022

Nevermind my previous comment. I see it is getting unwrapped correctly.

Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YingboMa YingboMa merged commit 01747e4 into SciML:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SymbolicDiscreteCallback fails for non-timebased events
3 participants