Make pantelides robust against unused derivative vars #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/pantelidesrobust
branch
3 times, most recently
from
0ff1f60 to
1f4dc07
Compare
This doesn't ordinarily happen, but for efficiency, I sometimes want to keep around differentiated variables that turn out not to actually be present in any equations. In this case, pantelides needs to make sure to only consider the highest order differentiated variable that *does* appear in an equation.
Keno
force-pushed
the
kf/pantelidesrobust
branch
from
1f4dc07 to
80849cf
Compare
Keno
added a commit
to Keno/ModelingToolkit.jl
that referenced
this pull request
Sep 27, 2022
Similar to SciML#1804, but for pss, rather than pantelides.
YingboMa
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't ordinarily happen, but for efficiency, I sometimes
want to keep around differentiated variables that turn out
not to actually be present in any equations. In this case,
pantelides needs to make sure to only consider the highest
order differentiated variable that does appear in an equation.