Skip to content

option to set all dummy derivatives to zero in linearize #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

baggepinnen
Copy link
Contributor

No description provided.

Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Julia 1.6 not like ControlSystemsMTK?

Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the tests such that ControlSystemsMTK isn't needed?

@baggepinnen
Copy link
Contributor Author

I don't think that ControlSystemsMTK is the problem, since ControlSystemsMTK tests pass on julia v1.6 without problems. I'd also like to keep it as kind-of a downstream test that the simplification in named_ss when input derivatives are present is working as expected.

Running it on v1.6 locally indicates that using ControlSystemsMTK runs, and it gets stuck on

@named link1 = Link(; m = 0.2, l = 10, I = 1, g = -9.807)

If I put @show in front of

@show @parameters t
@show D = Differential(t)

@show @named link1 = Link(; m = 0.2, l = 10, I = 1, g = -9.807)
@show @named cart = Translational.Mass(; m = 1, s_0 = 0)
@show @named fixed = Fixed()
@show @named force = Force()

I get this printed before it gets stuck

#= /home/fredrikb/.julia/dev/ModelingToolkit/test/linearize.jl:181 =# @parameters(t) = Symbolics.Num[t]
D = Differential(t) = Differential(t)

@baggepinnen
Copy link
Contributor Author

I disabled those tests for Julia v1.6, so the tests are passing now. We could open a separate issue with the freezing of

@named link1 = Link(; m = 0.2, l = 10, I = 1, g = -9.807)

@YingboMa YingboMa merged commit a47710b into master Jan 5, 2023
@YingboMa YingboMa deleted the fb/lind_dummy_der branch January 5, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants