Skip to content

Conversation

simeonschaub
Copy link
Contributor

This should fix #219.

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          15       15           
  Lines         497      497           
=======================================
  Hits          439      439           
  Misses         58       58
Impacted Files Coverage Δ
src/systems/diffeqs/first_order_transform.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3dbfa...317a1cc. Read the comment docs.

@ChrisRackauckas
Copy link
Member

Ahh, it's a case of #214. While this isn't a good solution in general, it's reasonable enough to understand for now, at least until we get a better #214 solution. Thanks!

@ChrisRackauckas ChrisRackauckas merged commit dca5f38 into SciML:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong solution for simple second order ODE
2 participants