Skip to content

fix: avoid infinite loops in MTKParameters initialization #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2024
Merged

fix: avoid infinite loops in MTKParameters initialization #2785

merged 3 commits into from
Jun 10, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

ChrisRackauckas and others added 2 commits June 9, 2024 17:19
@ChrisRackauckas
Only use the observed for simplification in MTKParameters construction
4c6e061 
You don't need it in the p itself, just wanted to use it for simplification, so don't loop over the whole thing. This fixes SciML/MethodOfLines.jl#397
@AayushSabharwal
fix: avoid infinite loops in MTKParameters initialization
730ad20
@AayushSabharwal AayushSabharwal mentioned this pull request Jun 10, 2024
Merged
@ChrisRackauckas ChrisRackauckas merged commit 3b8d2d6 into SciML:master Jun 10, 2024
@AayushSabharwal AayushSabharwal deleted the obsfixedpoint branch June 10, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AayushSabharwal @ChrisRackauckas