Skip to content

fix: support non-tunable parameters with DDEs #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: support non-tunable parameters with DDEs #3169

merged 2 commits into from
Oct 30, 2024

Conversation

AayushSabharwal
Copy link
Member

Close #3165

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal mentioned this pull request Oct 30, 2024
Closed
@ChrisRackauckas
Copy link
Member

test failure

@ChrisRackauckas ChrisRackauckas merged commit 2a1024a into SciML:master Oct 30, 2024
29 of 39 checks passed
@AayushSabharwal AayushSabharwal deleted the as/dde-non-tunables branch October 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DDE handling gives error if tunable=false on parameters
2 participants
@AayushSabharwal @ChrisRackauckas