Skip to content

SDEProblem from SDESystem fix #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2020
Merged

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented May 3, 2020

Seemed to be a typo in SDEProblem construction.

@isaacsas isaacsas changed the title Sdesysfix SDEProbelm from SDESystem fix May 3, 2020
@isaacsas isaacsas changed the title SDEProbelm from SDESystem fix SDEProblem from SDESystem fix May 3, 2020
@ChrisRackauckas ChrisRackauckas merged commit 61335f0 into SciML:master May 3, 2020
@isaacsas
Copy link
Member Author

isaacsas commented May 3, 2020

@ChrisRackauckas Would it make sense to also add:

function DiffEqBase.SDEProblem(sys::AbstractODESystem, args...; kwargs...)
    SDEProblem{true}(sys, args...; kwargs...)
end

similar to what you have for ODEProblems?

@isaacsas
Copy link
Member Author

isaacsas commented May 3, 2020

Sorry, I mean

function DiffEqBase.SDEProblem(sys::AbstractSDESystem, args...; kwargs...)
    SDEProblem{true}(sys, args...; kwargs...)
end

@isaacsas isaacsas deleted the sdesysfix branch May 3, 2020 17:46
@ChrisRackauckas
Copy link
Member

Oh yes, that would make sense.

@isaacsas
Copy link
Member Author

isaacsas commented May 3, 2020

Will submit shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants