Skip to content

Fix orientation getter #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

Fix orientation getter #3885

merged 1 commit into from
Aug 11, 2025

Conversation

baggepinnen
Copy link
Contributor

only used by Multibody.jl

Copy link
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master 975ba6c... master / 975ba6c...
ODEProblem 0.0788 ± 0.0062 s 0.0811 ± 0.0057 s 0.973 ± 0.1
init 0.0599 ± 0.0017 ms 0.0603 ± 0.0015 ms 0.992 ± 0.038
large_parameter_init/ODEProblem 1.05 ± 0.002 s 1.06 ± 0.0038 s 0.997 ± 0.004
large_parameter_init/init 0.11 ± 0.0025 ms 0.111 ± 0.0027 ms 0.992 ± 0.033
mtkcompile 0.0336 ± 0.0009 s 0.0345 ± 0.00075 s 0.975 ± 0.034
time_to_load 4.86 ± 0.059 s 4.86 ± 0.0058 s 0.998 ± 0.012
Memory benchmarks
master 975ba6c... master / 975ba6c...
ODEProblem 0.587 M allocs: 19.9 MB 0.587 M allocs: 19.9 MB 1
init 0.908 k allocs: 0.0479 MB 0.908 k allocs: 0.0479 MB 1
large_parameter_init/ODEProblem 4.31 M allocs: 0.167 GB 4.33 M allocs: 0.168 GB 0.992
large_parameter_init/init 1.75 k allocs: 0.0874 MB 1.75 k allocs: 0.0874 MB 1
mtkcompile 0.235 M allocs: 8.69 MB 0.235 M allocs: 8.69 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master 975ba6c... master / 975ba6c...
ODEProblem 0.0811 ± 0.0044 s 0.0809 ± 0.0056 s 1 ± 0.088
init 0.059 ± 0.012 ms 0.0589 ± 0.014 ms 1 ± 0.31
large_parameter_init/ODEProblem 1.11 ± 0.011 s 1.13 ± 0.023 s 0.985 ± 0.022
large_parameter_init/init 0.103 ± 0.012 ms 0.105 ± 0.011 ms 0.982 ± 0.15
mtkcompile 0.0347 ± 0.0014 s 0.0344 ± 0.00084 s 1.01 ± 0.047
time_to_load 4.93 ± 0.02 s 4.91 ± 0.037 s 1 ± 0.0086
Memory benchmarks
master 975ba6c... master / 975ba6c...
ODEProblem 0.576 M allocs: 18.7 MB 0.576 M allocs: 18.7 MB 1
init 0.815 k allocs: 0.0318 MB 0.815 k allocs: 0.0318 MB 1
large_parameter_init/ODEProblem 4.4 M allocs: 0.16 GB 4.43 M allocs: 0.161 GB 0.99
large_parameter_init/init 1.66 k allocs: 0.0712 MB 1.66 k allocs: 0.0712 MB 1
mtkcompile 0.235 M allocs: 8.12 MB 0.235 M allocs: 8.12 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@AayushSabharwal AayushSabharwal merged commit b6facb8 into master Aug 11, 2025
43 of 51 checks passed
@AayushSabharwal AayushSabharwal deleted the fixori branch August 11, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants