Skip to content

fix: unwrap inputs/outputs in System constructor #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

fix: unwrap inputs/outputs in System constructor #3960

merged 1 commit into from
Oct 10, 2025
+3 −0

Conversation

vyudu
Copy link
Member

@vyudu vyudu commented Oct 10, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Without unwrapping it will fail when trying to convert a Num into a BasicSymbolic

@ChrisRackauckas ChrisRackauckas merged commit b800623 into SciML:master Oct 10, 2025
29 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushSabharwal AayushSabharwal AayushSabharwal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyudu @AayushSabharwal @ChrisRackauckas