Skip to content

Fix array nested sparse cases #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2020
Merged

Fix array nested sparse cases #424

merged 6 commits into from
Jun 3, 2020

Conversation

wupeifan
Copy link
Contributor

@wupeifan wupeifan commented Jun 3, 2020 •
edited
Loading

Two changes:

  1. Adjusted the order in if...else in build_function. This is because SparseMatrixCSC <: AbstractArray is true. Therefore we need to adjust the order to trigger sparse builds before it goes through dense builds. I also added some Init=Expr[] to prevent empty calls on reduce.
  2. Changed the related test case. The previous one was a dense matrix therefore it didn't test the related codes.

This PR can replace #422 .

@wupeifan
Copy link
Contributor Author

wupeifan commented Jun 3, 2020

OK, it looks like all tests passed.

@YingboMa YingboMa merged commit 6afdbd2 into SciML:master Jun 3, 2020
@wupeifan wupeifan deleted the fix-arraynestedsparse branch June 3, 2020 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YingboMa YingboMa YingboMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wupeifan @YingboMa