define modelingtoolkitize for SDESystem with conversion tests #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dispatch for
modelingtoolkitizeof an SDESystem and allows us to convert the drift term from Ito to Stratonovich sense and vice versa. This should be useful to support also SDE adjoints for Ito SDEs, see SciML/SciMLSensitivity.jl#279 .The conversion factor of 1//2 is not strictly fixed, as in the adjoints, one needs to apply the correction term two times. Therefore, this could now be handled by
sys = modelingtoolkitize(prob,correction_factor=-1)