Overload propertynames and add @nonamespace
#882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is |
|
It's not used, but could be helpful if the user defines models hierarchically, and want to share a variable across two parallel level models. |
|
Then if it's user-facing, it should get a user-facing docstring. Or at least, a sentence above that which describes what it does and be put into the docs. Right now it looks like an internal. |
|
Yeah, I haven't decided how this should be used yet, so I haven't documented it yet. I think it will be helpful later when we implement inheritance, so I added it preemptively. |
|
alright. |
ChrisRackauckas
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.