ThermalConductor units issue

[kakila]

The documentation specifies that G is given in units of Power per Temperature, however this line:

ModelingToolkitStandardLibrary.jl/src/Thermal/HeatTransfer/ideal_components.jl

Line 120 in f7caceb

dT ~ G * Q_flow]

Multiplies G with a factor that is in Power units, giving a result in Power^2 per Temperature.
I guess this line needs to be a division: Q_flow / G; or G needs to be defined differently.

[kakila]

Why not define a single device that sets

0 ~ C * dT - Q_flow

and then make the *Conductor|*Resistor just syntax sugar built on top of this element?
This would be less code to maintain

[ven-k]

Yes ConvectiveConductor equation should be Q_flow ~ G * dT. Thanks for catching.
(Issue title needs to be fixed ThermalConductor -> (linked) ConvectiveConductor)

Why not define a single device that sets

We can define partial blocks and extend them when systems, @parameters, @variables can be reused. As R and G parameters are defined using the given values of R and G, we can't do this.

[kakila]

Yes ConvectiveConductor equation should be Q_flow ~ G * dT. Thanks for catching. (Issue title needs to be fixed ThermalConductor -> (linked) ConvectiveConductor)

Why not define a single device that sets

We can define partial blocks and extend them when systems, @parameters, @variables can be reused. As R and G parameters are defined using the given values of R and G, we can't do this.

Aren't G and R reciprocals from each other?