Don't export IdealGear from TranslationalPosition and TranslationalModelica #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalModelica - It isn't implemented in those libs
|
The export probably came with copy-paste, let's remove the export until a translational gear has been implemented 👍 |
baggepinnen
approved these changes
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 56.08% 54.96% -1.12%
==========================================
Files 48 35 -13
Lines 1578 1541 -37
==========================================
- Hits 885 847 -38
- Misses 693 694 +1 see 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This PR will need a follow-up-patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any implementation of IdealGear in these libs. @baggepinnen can we just drop them or do we want to reexport Rotational.IdealGear?