Skip to content

Conversation

bradcarman
Copy link
Contributor

Fixed a couple bugs/breaking changes from v2

  • Mechanical.Translational Position, Velocity, and Acceleration had all changed the initial position keyword (from s_0 to s__u_start). Turns out the initial position setting is never actually needed because the RealInput connector should always be driven by an absolute value, therefore this keyword is removed.
  • Calculating ForwardDiff derivatives with the Blocks.SampledData component was not working. Included ForwardDiff.value() to handle Dual type calls

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #202 (5633908) into main (c7b207d) will not change coverage.
The diff coverage is 23.07%.

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files          48       48           
  Lines        1602     1602           
=======================================
  Hits          891      891           
  Misses        711      711           
Files Changed Coverage Δ
src/Blocks/sources.jl 70.18% <0.00%> (ø)
src/Mechanical/Translational/sources.jl 43.47% <27.27%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YingboMa YingboMa merged commit 79e91be into main Jul 26, 2023
@YingboMa YingboMa deleted the bgc/sources branch July 26, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants