Fix documentation issues from #399 #400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable Digital Gates module and add proper exports (Not, And, Nand, Or, Nor, Xor, Xnor) - Enable Digital Components module and add exports (HalfAdder, FullAdder, MUX, DEMUX, Encoder, Decoder) - Enable Digital Sources module and add exports (PulseDiff, Set, Reset, Pulse) - Export DigitalPin connector and logic functions (_not, _and, _or, _xor) - Fix PNP transistor variable error: changed V_BE to V_EB in lines 303 and 307 - Add cross-references to MechanicalPort and RealOutput in AccelerationSensor, PositionSensor, and ForceSensor documentation - Reorganize Digital module includes to ensure logic functions are loaded before gates/components These changes address missing docstrings and incorrect formatting mentioned in the issue. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ChrisRackauckas
commented
Jul 26, 2025
Comment on lines
+303
to
+307
| V_EB - | ||
| ((C_jE0 * gamma_E * (1 - ((phi_E - Z_E) / phi_E))^(-gamma_E - 1)) / phi_E) * | ||
| (phi_E - Z_E) + (C_jE0) / (1 - (phi_E - Z_E) / phi_E)^gamma_E | ||
| else | ||
| (C_jE0) / (1 - V_BE / phi_E)^gamma_E | ||
| (C_jE0) / (1 - V_EB / phi_E)^gamma_E |
There was a problem hiding this comment.
Yeah that's a typo, my bad. I'm surprised it wasn't caught in the tests, it thought I added some for all branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses multiple documentation issues reported in #399:
Changes Made
Digital Module Fixes
gates.jl)components.jl)sources.jl)PNP Transistor Fix
V_BEwas used instead ofV_EBin the advanced continuation equations (lines 303 and 307)Documentation Cross-References
MechanicalPortandRealOutputin:Test plan
Fixes #399
🤖 Generated with Claude Code