-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added method ROK4a #2260
added method ROK4a #2260
Conversation
That's a choice. Just change |
Ohh I didn't know that. |
Every tableau can be used with every linear solver, and every linear solver can be used with every tableau. |
What's the next steps here? |
are the failed checks from this method? I thought they were general. Otherwise I will try and look for a fix. The "different project" I was talking about is something in Fortran where I needed the coefficients in the |
The failed checks were from the method, but it was just a typo so I handled it. Thanks! Did you benchmark it on a few problems to see how it works in practice? |
Thanks. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
added method ROK4a from Rosenbrock--Krylov Methods for Large Systems of Differential Equations
I dont think OrdinaryDiffEq currently utilizes Krylov Solvers for solving the Jacobian, but I need the
_transformtab(Alpha,Gamma,B,Bhat)
infunction ROK4aTableau()
for a different project, so I thought I might as well implement the method, if I already added the Tableau.