Skip to content

Conversation

chriselrod
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #74 (d7d30be) into master (7e01c7a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files           1        1           
  Lines         443      446    +3     
=======================================
+ Hits          438      441    +3     
  Misses          5        5           
Impacted Files Coverage Δ
src/Static.jl 98.87% <100.00%> (+<0.01%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

chriselrod and others added 3 commits June 29, 2022 21:04
Co-authored-by: Zachary P Christensen <zchristensen7@gmail.com>
Co-authored-by: Zachary P Christensen <zchristensen7@gmail.com>
@chriselrod
Copy link
Collaborator Author

I formatted it locally with JuliaFormatter v1.0.5, but it fails the format test on CI using the same version of the formatter.

@Tokazama
Copy link
Collaborator

I formatted it locally with JuliaFormatter v1.0.5, but it fails the format test on CI using the same version of the formatter.

Are we supposed to do this using specific SciML settings? I have to admit I haven't been keeping up with dev docs lately.

@chriselrod
Copy link
Collaborator Author

I formatted it locally with JuliaFormatter v1.0.5, but it fails the format test on CI using the same version of the formatter.

Are we supposed to do this using specific SciML settings? I have to admit I haven't been keeping up with dev docs lately.

That should happen automatically
https://github.com/SciML/Static.jl/blob/master/.JuliaFormatter.toml
Formatting passes now. I don't know what happened.
Merging master and reformatting fixed it.

@chriselrod chriselrod merged commit e6ae95b into master Jun 30, 2022
@chriselrod chriselrod deleted the realimag branch June 30, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants