Add error handling for vector expressions #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SciML#58 and SciML#106 by throwing an informative error when vector expressions are passed to integrate(). The error message guides users to use element-wise integration instead: integrate.([expr1, expr2, ...], x) Added tests to verify: - Vector expressions throw appropriate error - Scalar integration still works - Element-wise integration works as expected 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vector{Num}expressions. #58 and integrating vector of symbolic expressions #106 by throwing an informative error when vector expressions are passed tointegrate()integrate.([expr1, expr2, ...], x)Changes
src/integral.jlbefore the expand calltest/runtests.jlto verify:Test plan
This change prevents confusing behavior where vectors were incorrectly treated as constants and provides clear guidance to users on the correct approach for integrating multiple expressions.
🤖 Generated with Claude Code