Features/add mongo implementation #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
August 25, 2023 23:41
hchen2020
reviewed
Sep 4, 2023
| join ua in db.UserAgent on a.Id equals ua.AgentId | ||
| where ua.UserId == _user.Id | ||
| join u in db.User on ua.UserId equals u.Id | ||
| where u.ExternalId == _user.Id |
There was a problem hiding this comment.
Shuld be compatible with u.id == _user.Id.
Reference this fix:
added 3 commits
September 3, 2023 23:26
Oceania2018
reviewed
Sep 4, 2023
| public string AgentId { get; set; } = string.Empty; | ||
| public string UserId { get; set; } = string.Empty; | ||
| public string Title { get; set; } = string.Empty; | ||
| public string Dialog { get; set; } |
There was a problem hiding this comment.
Can we seperate Dialog to another collection? It will be optimized if UI only needs the conversation list.
Oceania2018
reviewed
Sep 4, 2023
| UserId = conv.UserId, | ||
| Id = conv.Id, | ||
| Title = conv.Title, | ||
| Dialog = conv.Dialog, |
There was a problem hiding this comment.
Dialog should be in seperate collection.
Oceania2018
reviewed
Sep 4, 2023
| { | ||
| public class RecordBase | ||
| { | ||
| public string? Id { get; set; } |
There was a problem hiding this comment.
Why is Id nullable? we can set the default as Guid.Empty
Oceania2018
reviewed
Sep 4, 2023
|
|
||
| [MaxLength(36)] | ||
| public string? ExternalId { get; set; } | ||
| public string ExternalId { get; set; } |
There was a problem hiding this comment.
ExternalId should be string?. It's nullable.
Oceania2018
reviewed
Sep 4, 2023
|
|
||
| public static class ListExtenstion | ||
| { | ||
| public static bool IsEmpty<T>(this IEnumerable<T> strList) |
There was a problem hiding this comment.
Is the name IsNullOrEmpty better?
Oceania2018
reviewed
Sep 4, 2023
| _routingService = routingService; | ||
| } | ||
|
|
||
| [HttpPost("/routing-items")] |
There was a problem hiding this comment.
Is it better /routing/items?
Oceania2018
reviewed
Sep 4, 2023
| return savedItems.Select(x => RoutingItemViewModel.FromRoutingItem(x)).ToList(); | ||
| } | ||
|
|
||
| [HttpPost("/routing-profiles")] |
Oceania2018
reviewed
Sep 4, 2023
| return savedProfiles.Select(x => RoutingProfileViewModel.FromRoutingProfile(x)).ToList(); | ||
| } | ||
|
|
||
| [HttpDelete("/routing-items")] |
Oceania2018
reviewed
Sep 4, 2023
| await _routingService.DeleteRoutingItems(); | ||
| } | ||
|
|
||
| [HttpDelete("/routing-profiles")] |
Oceania2018
reviewed
Sep 4, 2023
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0-preview.7.23375.6" /> |
Oceania2018
reviewed
Sep 4, 2023
| namespace BotSharp.Plugin.MongoStorage; | ||
|
|
||
| [BsonIgnoreExtraElements(Inherited = true)] | ||
| public class MongoBase |
There was a problem hiding this comment.
What's the difference between MongoBase with RecordBase?
added 13 commits
September 5, 2023 22:38
Oceania2018
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mongo storeage