Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the injection method of the SemanticKernel component. #213

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Refactor the injection method of the SemanticKernel component. #213

merged 5 commits into from
Nov 20, 2023

Conversation

xbotter
Copy link
Contributor

@xbotter xbotter commented Nov 20, 2023 •
edited
Loading

Changes:

  1. Change the injection of Semantic Kernel's components from IKernel to using IServiceCollection .
  2. Added mapping for the TextEmbedding and mapping for the MemoryStore.

Breaking Changes:

  1. move ITextEmbedding.GetVector -> ITextEmbedding.GetVectorAsync
  2. move ITextEmbedding.GetVectors -> ITextEmbedding.GetVectorsAsync

@xbotter
Add TextEmbeddingProvider and MemoryStoreProvider
f7ab61d
@xbotter
🔧 Update ITextEmbedding interface and its implementations
114fa98 
- Update ITextEmbedding interface to use async methods for getting vectors
- Update KnowledgeService to use async methods for getting vectors
- Update TextEmbeddingProvider and fastTextEmbeddingProvider to use async methods for getting vectors
- Update IntentClassifier to use async methods for getting vectors
- Update SemanticKernelTextEmbeddingProvider to use async methods for getting vectors
@xbotter
save stage
eb1b779
@xbotter
refactor semantic kernel Plugin
fe3e324
@xbotter
refactor SemanticKernelTextEmbeddingProvider
eccef74
@xbotter xbotter marked this pull request as ready for review November 20, 2023 14:06
@Oceania2018 Oceania2018 merged commit 4c1af4c into SciSharp:master Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oceania2018 Oceania2018 Oceania2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
RAG
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xbotter @Oceania2018