Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the correct type for QuadMesh data limits. #756

Merged
merged 2 commits into from
Apr 11, 2016

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 6, 2016

Matplotlib expects a Bbox, not a tuple of extents. This PR implements the fix suggested by @philippjfr in #745. I'm not sure about a test as I don't know how to trigger it other than saving with tight bbox_inches, though maybe that would be fine if to an io.BytesIO.

@pelson Since Cartopy 0.14 is totally broken in the notebook, I think we should merge and release 0.14.1 ASAP.

Fixes #745.

Matplotlib expects a Bbox, not a tuple of extents. This is only
exercised when using tight layout though, so not triggered in normal
tests.
@QuLogic QuLogic added this to the 0.14 milestone Apr 6, 2016
@pelson pelson merged commit cd989f0 into SciTools:v0.14.x Apr 11, 2016
@pelson pelson mentioned this pull request Apr 11, 2016
@QuLogic QuLogic deleted the quadmesh-bbox branch April 11, 2016 20:21
@QuLogic QuLogic modified the milestones: 0.14, 0.14.2 Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants