Add support for CompoundCRS #1227
Conversation
|
I couldn't find a |
rhattersley
force-pushed
the
pyepsg-compound-crs
branch
from
e0209b0
to
92a2291
Compare
rhattersley
force-pushed
the
pyepsg-compound-crs
branch
from
92a2291
to
8ab2616
Compare
rhattersley
force-pushed
the
pyepsg-compound-crs
branch
from
8ab2616
to
c2b183d
Compare
|
Do I need to do something to fix the appveyor problem? Or is #1224 tackling this? |
lib/cartopy/_epsg.py
Outdated
| @@ -41,7 +41,9 @@ class _EPSGProjection(ccrs.Projection): | |||
| def __init__(self, code): | |||
| import pyepsg | |||
| projection = pyepsg.get(code) | |||
| if not isinstance(projection, pyepsg.ProjectedCRS): | |||
| if not (isinstance(projection, pyepsg.ProjectedCRS) or | |||
| (hasattr(pyepsg, 'CompoundCRS') and | |||
There was a problem hiding this comment.
I'd be extremely tempted to update pyepsg dependency to >=0.4. Relevant locations : https://github.com/SciTools/cartopy/blob/master/requirements/epsg.txt and https://github.com/SciTools/cartopy/blob/master/INSTALL
There was a problem hiding this comment.
Bump the dependency and simplify this logic? Happy to do so if that's what you prefer.
There was a problem hiding this comment.
Let's go for it (bump and simplify).
|
Should be good to go now. 👍 |
|
Great, thanks @rhattersley. And welcome back to cartopy contributions 👍 😉 |
|
Nice to be back 😉 |
Rationale
Allow Cartopy to make use of EPSG codes that define a compound CRS.
See rhattersley/pyepsg#10.
Implications
A projection can now be created using an EPSG code for a compound CRS, whereas previously it would have raised an error.