-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list parameters passed to artists #910
Conversation
One test failure.
Can I update the date at the top of the affected file? |
You should if you changed it. |
Looks like you'll also need to sign the CLA as well. |
I signed the CLA form and emailed a copy to the address and it's been a while without a reply. |
Ping @marqh, I think? |
1ab118b
to
bee9956
Compare
It would be great to have tests for all feature types, but it does not look easy. Any ideas on to generate good tests? For the Rebased and travis did not like it. Maybe it now requires #926. |
bee9956
to
3867175
Compare
**Problem** When artists are being drawn, the geometries outside the viewport are removed before the drawing. The parameters that correspond to removed geometries are left unchanged and so they are ill-matched with the remaining geometries. **Solution** Keep track of which geometries are removed, and remove the corresponding elements in the parameter values. Fixes SciTools#580
3867175
to
fefc173
Compare
fefc173
to
a6a9d6f
Compare
This has been a really valuable PR that has ultimately led to #1019, which is my preferred direction for finer control of the style through As such, I don't think we need this PR open any further. Thanks again for your input on this @has2k1 - it has been super useful, and I'm really pleased with the outcome, which I consider to be an extremely powerful interfaces for all sorts of purposed. 👍 |
Problem
When artists are being drawn, the geometries outside the viewport
are removed before the drawing. The parameters that correspond to
removed geometries are left unchanged and so they are ill-matched
with the remaining geometries.
Solution
Keep track of which geometries are removed, and remove the
corresponding elements in the parameter values.
Fixes #580
Also