Exploring_UV_extinction_curves_pt1 #14
Conversation
Updates to old notebook: - Changed SMC target to new one - Extended wavelength range studied to better see the differences between SMC and LMC extinction curves - Created exercise for the read to see (with solutions) - Added citations/additional resources
Updates to old notebook: - Added new citations - Included SIMBAD query using astroquery - Started included parametrization of curves (not finished, LMC fit not correct yet)
Updates to old notebook:
- Added new citations
- Fixed parametrization of curves
* Note: SMC target chosen has sparse data, which makes data-fitting not optimal, maybe example target should be changed
- Fixed NaN values in data
- Added documentation to functions
- Small changes to overall structure and outputs format
Initial draft for tutorial UV_excess_in_low_mass_stars. So far: - Initial structure of notebook - Tentative learning goals - Brief intro in light curves and csv files - Example of light curve with gPhoton (standard example to learn to use gPhoton, not related to the goal of notebook) - Additional resources + citations
Add files via upload
Initial draft for UV_excess_for_low_mass_stars So far: - Initial structure of notebook - Tentative learning goals - Short introduction on light curves and csv files - Create and plot light curve using gPhoton (standard example to learn how to use gPhoton, not related with goal of tutorial) - Additional resources + citations + imports
Package requirements for Tutorial Part 1
Tutorial + Solution Notebook for Part 1
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Change of name for part 1 + small adjustments
Renaming
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
This may be a naive comment because my background is with so much longer wavelengths than UV ;-) But could the title be more descriptive? I will read on to see if I have a suggestion.
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
querys --> queries, but can "data" be more specific. E.g. Search the MAST archive by Target Name and narrow down the results by [some criteria?]
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
are created by representing k(λ−V)
Some wording: I would change "representing" to "plotting"
For Extinction: can clarify, difference in what magnitudes? Is it the difference between the magnitude of the band when observed through dust vs. not? While it's abbreviated as A_lambda, I don't see that expression in the equation below. Is A_lambda equivalent to something else in the equation? Is it A(lambda)?
Likewise, what is E in the equation? Or, if not worth saying, maybe just remove that part!
There is some markdown error with the Note.
At this point, as the reader, I am wondering, am I going to be making an extinction curve out of a spectrum? Or will I be able to directly download an extinction curve from the archive? So some more clarification of what we will do will help. I know this is one of a two-part tutorial and I think it's okay to say that - something like, in Part 1 you will do this, in Part 2 you will do that. I will defer to the STScI folks for specific style guidelines.
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
"Searching the MAST archive by target name and downloading spectra" (If that's accurate?)
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
Some of this information would be really helpful up in the introduction! For example, introducing that we will be using data from IUE and maybe one sentence about what it is. A link to a mission webpage for an interested user would also help.
For the heads-up, as the reader new to UV, I kind of feel like "Oh no, how I am supposed to know the correct name of my target?" Is there a standardized list somewhere, or a name resolver, that you can link to? In other words, how did you know the correct name? (What would happen if you put the "z" in the name, would it still work?)
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
It would be good to give the reader a bit more info on what some of the columns in the table above mean. How did you decide to choose "swp22372" out of all the possible options, for example? Was there information in the table that affected that choice? It might be particularly good to draw the reader's attention to the Product Type column. I'm not sure what else might be relevant - what do you look at when analyzing your choices? "Description?"
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
Similar to the above comment... it's weird because we kind of already "know" which one we want to choose to make the tutorial work correctly. But it can be useful to "pretend" that you don't already know so you can model the procedure to the user. So I'd recommend also showing how to find the correct line, if you didn't already know it was row 1144. (Also that makes sure it's robust if for some reason the ordering of the rows changes in a future update or something!)
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
Similar question - how did you know to folder by that extension? I presume that the product list returns many types of products, many of which are auxiliary, and this one is the only Science one?
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
Might just be a wording thing, but "a complete image" confused me at first because I was like aren't these spectra, not images? Perhaps "in order to have a more complete understanding of the extinction curve across a broad range of wavelengths,"
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
Here's some good info that would be helpful for the reader in the introduction; giving a little more information about what we're going to do. We want to find the spectra of two stars, one reddened and one unreddened. What is their relationship to one another... or is there one? (Other than that they are of the same spectral type?) Were these chosen from a catalog, if so which one (e.g. you could cite it)?
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
I just wonder, stylistically, since you've already shown a product result list, is it necessary to print the output again with this new list? In other words, the reader has been shown what it looks like, and now will know e.g. what columns are there. Again, it's a stylistic choice, feel free to determine for yourself what's best here.
Then the previous comments apply below too - how did you now to choose these specific rows, etc.
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
I really like this whole section, it can be overwhelming to examine new data files but this pinpointed me exactly to the things I need to know - what are the columns, what are the units! The one remaining question I have are on some of the choices for this particular cell. Can you add some more detail on why 54-61 were chosen in particular? Are these things the reader will use as they continue through the tutorial?
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe it's just my habit, but I think it's great now that we have a spectrum to visualize it with a simple plt.plot() call. What would be useful about that is to also then be able to draw the reader's attention to the fact that some of the flux values in the lw spectrum are negative. I presume this is due to just large errors at the very edge of the band coupled with background subtraction. Then you can warn them, we will need to take the log of the flux which we can't do for negative numbers.
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
Could add: The change NaN function below examines a pair of wavelength and flux pairs. We'll use it on both stars simultaneously. It will delete the rows of all columns (fluxes and wavelengths) if either star's flux value is negative in that row.
Reply via ReviewNB
| @@ -0,0 +1,1433 @@ | |||
| { | |||
There was a problem hiding this comment.
This is the first time it's mentioned that the stars we were working with were in the SMC, so that can go in the introduction.
Also, it may be leftover language from before this tutorial was split into 2 parts, but we haven't really obtained the extinction curve yet, right? So maybe "Try to obtain the spectra necessary to create an extinction curve..." etc.
Reply via ReviewNB
cpsanchez
changed the title
|
I have worked on all the comments proposed by Julia (thank you again for taking the time to review it) for Part 1! The only thing I have not changed is the plotting the spectrum in this part, because we made the division of the tutorials for 1. Data downloading and 2. Data visualization, so I think it may take away from Part 2 if we already plot it in the first part, but if everyone agrees that we should also address it in part 1 it is an easy and quick fix! |
Part 1 of tutorial: "Exploring UV extinction curves Pt. 1"
Contains: