Improve arguments blocks handling (Matlab) #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"arguments" is a valid function argument name. It should not be recognized as a keyword in a function declaration line.
Matlab allows multiple sequential arguments blocks imposing restrictions on different kinds of arguments.
A semicolon must behave the same as a comment between a function declaration line and and an arguments block beginning. A semicolon must end a function declaration even if there's no following line break.
nyamatongwe
changed the title
nyamatongwe
pushed a commit
that referenced
this pull request
Jun 27, 2023
"arguments" is a valid function argument name. It should not be recognized as a keyword in a function declaration line.
nyamatongwe
pushed a commit
that referenced
this pull request
Jun 27, 2023
Matlab allows multiple sequential arguments blocks imposing restrictions on different kinds of arguments.
nyamatongwe
pushed a commit
that referenced
this pull request
Jun 27, 2023
A semicolon must behave the same as a comment between a function declaration line and and an arguments block beginning. A semicolon must end a function declaration even if there's no following line break.
|
Committed with additions to history file. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argumentsis context-dependent in Matlab: sometimes it's a valid identifier, and sometimes it's a keyword. This PR:argumentsblocks;argumentsblocks in one line functions (the syntax is probably not used in the real world);argumentsblock could break folding.The corresponding tests are included.